Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix font download #3322

Merged
merged 3 commits into from
Mar 23, 2024
Merged

Fix font download #3322

merged 3 commits into from
Mar 23, 2024

Conversation

Minnozz
Copy link

@Minnozz Minnozz commented Mar 18, 2024

  • Flower container needs static_volume because BookwyrmConfig wants the font
  • Don't raise an exception when the download destination dir already exists
  • Log the exception itself if something goes wrong

@BartSchuurmans
docker-compose.yml: mount static_volume for flower
7484185 
Because flower also uses BookwyrmConfig, it wants to download fonts, and will download them to an
incorrect location if the static_volume is not mounted.
@BartSchuurmans
Font download: destination dir is allowed to exist
3367b20 
Without this argument, an existing directory (but not the file) causes an error.
@Minnozz Minnozz marked this pull request as ready for review March 18, 2024 19:40
@mouse-reeve mouse-reeve merged commit 20db968 into bookwyrm-social:main Mar 23, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mouse-reeve mouse-reeve Awaiting requested review from mouse-reeve

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Minnozz @mouse-reeve @BartSchuurmans