Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework author search #3325

Merged
merged 5 commits into from
Mar 25, 2024
Merged

Rework author search #3325

merged 5 commits into from
Mar 25, 2024

Conversation

Minnozz
Copy link

@Minnozz Minnozz commented Mar 19, 2024 •
edited
Loading

  • Set up trigger to populate bookwyrm_author.search_vector with author name and aliases
    • Add tests
  • Add author aliases to book search vector
    • Add tests
  • Base author search on SearchQuery instead of TrigramSimilarity

Fixes #3063

@Minnozz Minnozz self-assigned this Mar 19, 2024
@Minnozz Minnozz force-pushed the author-search-vector branch 3 times, most recently from 5809935 to 4ef3b2a Compare March 20, 2024 11:24
@Minnozz Minnozz changed the title Switch author search from TrigramSimilarity to SearchQuery Rework author search Mar 20, 2024
@Minnozz Minnozz force-pushed the author-search-vector branch 3 times, most recently from 1e76454 to 31b7c5f Compare March 22, 2024 21:06
@Minnozz Minnozz marked this pull request as ready for review March 22, 2024 21:11
@Minnozz Minnozz requested a review from dato March 22, 2024 21:11
@mouse-reeve mouse-reeve merged commit 7192449 into bookwyrm-social:main Mar 25, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dato dato Awaiting requested review from dato

Assignees

@Minnozz Minnozz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Author aliases not always recognised when searching for books
3 participants
@Minnozz @mouse-reeve @BartSchuurmans