add SP3QSAJQ4EA8WXEDSRRKMZZ29NH91VZ6C5X88FGZQ/crashpunks-v1 #1
Conversation
| ) | ||
| ) | ||
| (define-read-only (get-sale-data (nftIndex uint)) | ||
| (match (map-get? nft-sale-data {nft-index: nftIndex}) |
There was a problem hiding this comment.
use unwrap! for better readability
| ) | ||
| ) | ||
|
|
||
| ;; read only methods |
There was a problem hiding this comment.
most read-only functions do not need a result of type response, better to use plain value if not required by traits.
Specifying read-only in traits might change with Stacks 2.1: stacks-network/stacks-core#1981
| (tokenSymbol the-token-symbol))) | ||
| ) | ||
| ) | ||
| (define-private (get-all-data (nftIndex uint)) |
| (+ split (unwrap! (pay-royalty payer myMintPrice (unwrap! (element-at mintAddresses u1) payment-address-error) (unwrap! (element-at mintShares u1) payment-share-error)) payment-share-error)) | ||
| (+ split (unwrap! (pay-royalty payer myMintPrice (unwrap! (element-at mintAddresses u2) payment-address-error) (unwrap! (element-at mintShares u2) payment-share-error)) payment-share-error)) | ||
| (+ split (unwrap! (pay-royalty payer myMintPrice (unwrap! (element-at mintAddresses u3) payment-address-error) (unwrap! (element-at mintShares u3) payment-share-error)) payment-share-error)) | ||
| ;; (print {evt: "paymint-split", nftIndex: nftIndex, payer: payer, mintPrice: myMintPrice, txSender: tx-sender}) |
| ) | ||
| ;; ignore royalty payment if its to the buyer / tx-sender. | ||
| (if (not (is-eq tx-sender payee)) | ||
| (unwrap! (stx-transfer? split payer payee) transfer-error) |
There was a problem hiding this comment.
Information about the transfer error is lost. Is that intentional? If there is only one execution path that returns error code between 1 and 4, use (try! (stx-transfer? ...))
| ;; mint twenty tokens | ||
| (define-public (collection-mint-token-twenty (signature (buff 65)) (message (buff 32)) (hashes (list 20 (buff 32))) (meta-urls (list 20 (string-ascii 256))) (maxEditions uint) (editionCost uint) (clientMintPrice uint) (buyNowPrice uint)) | ||
| (begin | ||
| (unwrap! (collection-mint-token signature message (unwrap! (element-at hashes u0) not-allowed) (unwrap! (element-at meta-urls u0) not-allowed) maxEditions editionCost clientMintPrice buyNowPrice) not-allowed) |
There was a problem hiding this comment.
message is the same for the 20 asset hashes. Bad actors could front run and mint with the same message and signature.
| ) | ||
|
|
||
| (define-public (transfer-memo (id uint) (sender principal) (recipient principal) (memo (buff 34))) | ||
| (let ((result (transfer id sender recipient))) |
There was a problem hiding this comment.
Alternative
(begin
(try! (transfer id sender recipient))
(print memo)
(ok true))
| (map-set nft-sale-data { nft-index: nftIndex } { sale-cycle-index: (+ saleCycleIndex u1), sale-type: u0, increment-stx: u0, reserve-stx: u0, amount-stx: u0, bidding-end-time: u0}) | ||
| ;; finally transfer ownership to the buyer (note: via the buyers transaction!) | ||
| (print {evt: "buy-now", nftIndex: nftIndex, owner: owner, recipient: recipient, amount: amount}) | ||
| (nft-transfer? crashpunks nftIndex owner recipient) |
There was a problem hiding this comment.
buy-now is not guarded once the sale data is set
| (define-public (buy-now (nftIndex uint) (owner principal) (recipient principal)) | ||
| (let | ||
| ( | ||
| (saleType (unwrap! (get sale-type (map-get? nft-sale-data {nft-index: nftIndex})) amount-not-set)) |
There was a problem hiding this comment.
extract (unwrap! (map-get? nft-sale-data {nft-index: nftIndex}) err-not-found) into a variable for better readability
| ) | ||
| ) | ||
|
|
||
| (define-public (collection-mint-token (signature (buff 65)) (message-hash (buff 32)) (asset-hash (buff 32)) (metaDataUrl (string-ascii 256)) (maxEditions uint) (editionCost uint) (clientMintPrice uint) (buyNowPrice uint)) |
There was a problem hiding this comment.
metaDataUrl can be set by users freely. That value is returned by get-token-uri
| (err code))))) | ||
|
|
||
| ;; see operable-trait | ||
| (define-public (set-approved (nftIndex uint) (operator principal) (approved bool)) |
There was a problem hiding this comment.
The function should allow to set-approved for nfts owned at any time, not just right now.
| ) | ||
| ) | ||
|
|
||
| (define-read-only (is-approved (nftIndex uint) (address principal)) |
There was a problem hiding this comment.
Naming can be confusing because this function always approves any address if the caller is the tx-sender or contract-caller
|
nft index starts at 0 in this contract - should this be changed to 1 ? |
No description provided.