Preserve group association and access settings #391
Conversation
Adds minimum bottom margin to fix layout problems.
This makes the "…and 10 more" text at the end of the tags list a control for the expansion of the tags list. I also moved the top tags button presentation class to a new class name separate from the class name used to fire the expansion action.
In some cases, users can edit docs but can't manage group associations or access settings. Previously, those attributes were being blanked out during an edit by a user who could edit but not manage the doc, losing group association and resetting the access settings to default.
|
Wow, good catch. There are a number of other tickets that are probably On 03/24/2014 12:17 PM, dcavins wrote:
|
|
Thanks again for this. I can't accept it quite as-is, because it breaks some existing functionality (the references to $_POST inside of |
|
Yes, I wondered about the reliance on the status of a $_POST array key, Thanks a lot for the excellent plugin. On Tue, Mar 25, 2014 at 2:59 PM, Boone Gorges notifications@github.comwrote:
|
|
Hooray! Thanks all around. |
Hi Boone-
One of my observant users noticed that while editing docs associated with a group that did not belong to her, several doc attributes were being lost on edit--the group association and access settings. Upon looking into it, I realized that the edit form doesn't include sections for users who can't "manage" the doc, but the save routine was expecting values from those fields.
I've added a couple of checks for $_POST value existence and emptiness that take those other situations into account. I left several notes in the code to explain the logic branches; please let me know if you have any questions.
Sorry I didn't notice this problem earlier!