Notification emails contain content from the wrong post

[matthewf-ucsd]

When a user creates a new post to a group blog, the notifications that are sent out to users contain the content from the wrong post.

In bp-activity-subscription-functions.php, bpges_generate_notification(), after the comment:

// Use bbPress filtered post content and reapply GES filter... sigh.

... since the call to get_post_field( 'post_content', $activity->secondary_item_id, 'raw' ) is being made in the context of the primary blog, it is getting the content for an unrelated post and sending that in the notification to group users

This can lead to exposing, for example, posts to forums of private groups.

I'm going to work around this by switching back to the post's blog before getting the post text:

switch_to_blog(get_groupblog_blog_id( $group->id ));
$the_content = get_post_field( 'post_content', $activity->secondary_item_id, 'raw' );
switch_to_blog( bp_get_root_blog_id() );

[r-a-y]

Thanks for the catch, @matthewf-ucsd.

Bug was introduced by me in commit 912056c. Will have a fix shortly.

[matthewf-ucsd]

Thank you for the fast fix!

[boonebgorges]

Thanks, @r-a-y !