Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate URL module #19

Merged
merged 2 commits into from
Apr 20, 2021
Merged

deprecate URL module #19

merged 2 commits into from
Apr 20, 2021

Conversation

boonious
Copy link
Owner

This PR deprecates Hui.URL struct and module for a simpler function core, by using existing Elixir structures.

Solr endpoints, headers and options can now be specified via a url string, an atomic key pointing to a configuration or a {url, headers, options} tuple where:

If HTTPoison is used, advanced HTTP options such as the use of connection pools may also be specified via options.

@coveralls
Copy link

coveralls commented Apr 15, 2021

Pull Request Test Coverage Report for Build 318

  • 7 of 7 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.5%) to 98.54%

Totals Coverage Status
Change from base Build 311: 0.5%
Covered Lines: 135
Relevant Lines: 137

💛 - Coveralls

@boonious boonious linked an issue Apr 15, 2021 that may be closed by this pull request
@boonious boonious merged commit 55287d0 into master Apr 20, 2021
@boonious boonious deleted the deprecate-url-module branch April 20, 2021 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate Hui.URL module
2 participants