[ ddaynew365 ] 요청 페이지 레이아웃 구현 및 더미 데이터 연동 #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
나도 태홍이 의견에 동감 // flex-wrap 사용해서 그런거기 때문에 바깥 width를 조절해주면 될것같음 |
|
2번째 질문 내용이 상세하지않아서 잘 이해가 가진 않는데 // |
jin-Pro
approved these changes
Nov 4, 2021
| display: flex; | ||
| width: 100vw; | ||
| height: 100vh; | ||
| flex-direction: row; |
There was a problem hiding this comment.
style은 function 바깥으로 쓰는게 좋아보여요
지금 코드는 컴포넌트 생성될때마다 style 변수를 계속 생성해야해요
Noelsky-code
approved these changes
Nov 4, 2021
| "webRoot": "${workspaceFolder}/src" | ||
| } | ||
| ] | ||
| } |
There was a problem hiding this comment.
launch.json은 .gitIgnore에 올려주셔야 할거 같아요
| const item = await getRequestInfo(); | ||
| item?.data.forEach((data: RequestType) => { | ||
| return data.from === myId ? setRequestForMe((prev) => [...prev, data.info]) : setRequestToMe((prev) => [...prev, data.info]); | ||
| }); |
There was a problem hiding this comment.
혹시 return 을 하지 않았을 때 에러가 떳나요?
forEach 내부에서 return 을 한 이유가 궁금합니다
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
내용
고민