메인페이지 Skeleton UI 적용 #217
Merged
메인페이지 Skeleton UI 적용 #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
⚡️ Lighthouse report!
|
doputer
approved these changes
Dec 6, 2022
frontend/pages/index.tsx
Outdated
| @@ -12,19 +12,27 @@ export default function Home() { | |||
| const { data: newestBookList, execute: getNewestBookList } = useFetch(getOrderedBookListApi); | |||
| const { data: popularBookList, execute: getPopularBookList } = useFetch(getOrderedBookListApi); | |||
|
|
|||
| const [isLoading, setIsLoading] = useState<boolean>(true); | |||
There was a problem hiding this comment.
로딩 중인 상태는 useFetch에서 제공해주는 것이 좋겠네요. 내일 중으로 개선해놓겠습니다.
There was a problem hiding this comment.
그럼 이 부분 제가 수정해서 이번 PR에 담아놓을게요!
Comment on lines
+7
to
+36
| const SkeletonItem = styled.div` | ||
| width: 100%; | ||
| height: 30px; | ||
| background-color: #f2f2f2; | ||
| position: relative; | ||
| overflow: hidden; | ||
| border-radius: 4px; | ||
|
|
||
| @keyframes skeleton-gradient { | ||
| 0% { | ||
| background-color: rgba(165, 165, 165, 0.1); | ||
| } | ||
| 50% { | ||
| background-color: rgba(165, 165, 165, 0.3); | ||
| } | ||
| 100% { | ||
| background-color: rgba(165, 165, 165, 0.1); | ||
| } | ||
| } | ||
|
|
||
| &:before { | ||
| content: ''; | ||
| position: absolute; | ||
| top: 0; | ||
| left: 0; | ||
| width: 100%; | ||
| height: 100%; | ||
| animation: skeleton-gradient 1.5s infinite ease-in-out; | ||
| } | ||
| `; |
There was a problem hiding this comment.
스켈레톤 UI 적용을 위해서 기존의 스타일 컴포넌트와 동일한 컴포넌트가 생성된게 맞을까요? 아니면 대체된거라고 보면 될까요?
스켈레톤에 해당하는 부분만 props로 처리할 수 있는지 같이 고민해보면 좋을 것 같습니다.
There was a problem hiding this comment.
UX적으로 편안함을 주기 위해서 최대한 유사한 스타일의 컴포넌트를 만들다 보니 복사 한 후 필요한 부분만 남긴거라 동일하다고 보기는 어려울 것 같아요!
개인적으로 props로 처리하면 오히려 원본 컴포넌트에 대한 이해가 낮을 것 같아서 새로운 컴포넌트 대체 방식이 좋을 것 같아요 : )
parkhyeonki
approved these changes
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
메인 페이지에서 로딩 되는 동안 컴포넌트가 없어서 푸터가 올라오는 문제가 있어서 Skeleton UI를 넣어서 보완하고자 함
변경 사항
참고 사항
스크린샷
관련 이슈