Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

intelligent compression #227

Open
vinniefalco opened this issue Jan 18, 2017 · 4 comments
Open

intelligent compression #227

vinniefalco opened this issue Jan 18, 2017 · 4 comments
Assignees
@alandefreitas
Labels
Feature
Projects
Taming the Beast

Comments

@vinniefalco
Copy link
Member

When the message or frame is small or empty we might be smarter about the compression settings (or even if we compress at all).
@vinniefalco
Copy link
Member Author

The config for the stream could have a size threshold parameter

@vinniefalco vinniefalco reopened this Jun 16, 2022
@alandefreitas alandefreitas mentioned this issue Jul 5, 2022
Closed
alandefreitas added a commit to alandefreitas/beast that referenced this issue Jul 5, 2022
@alandefreitas
per-message compression options
6dafe02 
fix boostorg#226, boostorg#227
@alandefreitas alandefreitas mentioned this issue Jul 5, 2022
Closed
@alandefreitas alandefreitas linked a pull request Jul 5, 2022 that will close this issue
per-message compression options #2480
Closed
alandefreitas added a commit to alandefreitas/beast that referenced this issue Jul 5, 2022
@alandefreitas
per-message compression options
10ad742 
fix boostorg#226, boostorg#227
klemens-morgenstern pushed a commit that referenced this issue Oct 3, 2022
@alandefreitas @klemens-morgenstern
per-message compression options
bd69638 
fix #226, #227
@klemens-morgenstern
Copy link
Collaborator

For reference

https://www.igvita.com/2013/11/27/configuring-and-optimizing-websocket-compression/

@klemens-morgenstern
Copy link
Collaborator

it seems this spec is already implemented: https://datatracker.ietf.org/doc/html/draft-ietf-hybi-permessage-compression

is this issue still open or do we need to refine the logic?
@vinniefalco

@vinniefalco
Copy link
Member Author

A simple algorithm is fine, a configurable size threshold below which, we don't compress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alandefreitas alandefreitas

Labels
Feature
Projects
Taming the Beast
Triage
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

per-message compression options alandefreitas/beast
3 participants
@vinniefalco @alandefreitas @klemens-morgenstern