Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCache cache not saved #166

Closed
Flamefire opened this issue Jun 4, 2022 · 2 comments
Closed

CCache cache not saved #166

Flamefire opened this issue Jun 4, 2022 · 2 comments

Comments

@Flamefire
Copy link
Collaborator

Flamefire commented Jun 4, 2022

Looks like the ccache action doesn't actually save the cache. This is from the post-step:

Cache hit occurred on the primary key ubuntu-20.04--gcc-11, not saving cache.

So it doesn't update the cache! O.o

We could use a dedicated ccache action like https://github.com/hendrikmuhs/ccache-action which handles the key-creation etc. for us or do it manually (see fix_ccache branch which I'm testing right now)

@Flamefire
Copy link
Collaborator Author

Flamefire commented Jun 4, 2022

Closed (for now) by 699bb3b which takes the "manual" approach to not needing to trust another action

Flamefire added a commit to Flamefire/assign that referenced this issue Jun 4, 2022
Flamefire added a commit to Flamefire/concept_check that referenced this issue Jun 4, 2022
Flamefire added a commit to boostorg/locale that referenced this issue Jun 4, 2022
@Flamefire
Copy link
Collaborator Author

Note for library authors: the following change reuse the existing (old) cache if any:

          key: ${{matrix.os}}-${{matrix.container}}-${{matrix.compiler}}-${{github.sha}}
          restore-keys: |
            ${{matrix.os}}-${{matrix.container}}-${{matrix.compiler}}-
            ${{matrix.os}}-${{matrix.container}}-${{matrix.compiler}}

For new caches and after the transition only the first restore key is required

Flamefire added a commit to Flamefire/date_time that referenced this issue Jun 5, 2022
Flamefire added a commit to Flamefire/dynamic_bitset that referenced this issue Jun 5, 2022
Flamefire added a commit to Flamefire/format that referenced this issue Jun 5, 2022
Flamefire added a commit to Flamefire/logic that referenced this issue Jun 5, 2022
Flamefire added a commit to Flamefire/mpl that referenced this issue Jun 5, 2022
Flamefire added a commit to Flamefire/interval that referenced this issue Jun 5, 2022
Flamefire added a commit to Flamefire/pool that referenced this issue Jun 5, 2022
Flamefire added a commit to Flamefire/property_map that referenced this issue Jun 5, 2022
Flamefire added a commit to Flamefire/ptr_container that referenced this issue Jun 5, 2022
Flamefire added a commit to Flamefire/tokenizer that referenced this issue Jun 5, 2022
Flamefire added a commit to Flamefire/uuid that referenced this issue Jun 5, 2022
jeking3 pushed a commit to boostorg/uuid that referenced this issue Jun 7, 2022
jeking3 pushed a commit to boostorg/format that referenced this issue Jun 7, 2022
mclow pushed a commit to boostorg/tokenizer that referenced this issue Jun 24, 2022
mclow pushed a commit to boostorg/property_map that referenced this issue Jun 24, 2022
mclow pushed a commit to boostorg/pool that referenced this issue Jun 24, 2022
mclow pushed a commit to boostorg/interval that referenced this issue Jun 24, 2022
mclow pushed a commit to boostorg/mpl that referenced this issue Jun 24, 2022
mclow pushed a commit to boostorg/logic that referenced this issue Jun 24, 2022
mclow pushed a commit to boostorg/dynamic_bitset that referenced this issue Jun 24, 2022
JeffGarland pushed a commit to boostorg/date_time that referenced this issue Sep 20, 2022
JeffGarland added a commit to boostorg/date_time that referenced this issue Oct 31, 2022
* fix typo in time_period docs (#212)

Co-authored-by: Quinn O'Connor <qoconnor@fastenal.com>

* Fix constexpr of gregorian::date::date(special_values) to improve perf (#214)

GCC up to at least 10.2 fail to resolve
gregorian::date::date(special_values) as constexpr function due to
assignment to *this within the constructor. Refactoring constructor to
initialize the instance once leads to large performance improvement.

* Avoid using likely function as multiple projects define a likely macro (#216)

* Iso doc fixes (#215)

* to_iso_*string() use "." as fractional separator

The fractional separator for the various to_iso_* methods
is "." not "," (per to_iso_string_type() implementation).
Fix the documentation to match the implementation.

* use "ISO 8601" not "iso" in documentation

The standard is "ISO 8601", so use that instead
of just "iso" or "ISO" in comments and documentation.

* fractional seconds only included if non-zero (#110)

Consistently document that the fractional seconds
are only included if non-zero.

Use "where fffffffff" not "were fff".

* Fix ccache saving on cache hit (#211)

See boostorg/boost-ci#166

* chore: bump macos runner version (#213)

GitHub Action is sunsetting the macOS 10.15 Actions runner. It will stop working intermittently until being completely removed by 2022-8-30: https://github.blog/changelog/2022-07-20-github-actions-the-macos-10-15-actions-runner-image-is-being-deprecated-and-will-be-removed-by-8-30-22

Co-authored-by: Quinnsicle <qtoconnor@gmail.com>
Co-authored-by: Quinn O'Connor <qoconnor@fastenal.com>
Co-authored-by: Povilas Kanapickas <povilas@radix.lt>
Co-authored-by: Antony Polukhin <antoshkka@gmail.com>
Co-authored-by: Luke Mewburn <luke@mewburn.net>
Co-authored-by: Alexander Grund <Flamefire@users.noreply.github.com>
Co-authored-by: Baoshuo Ren <i@baoshuo.ren>
mclow pushed a commit to boostorg/assign that referenced this issue Nov 10, 2022
mclow pushed a commit to boostorg/concept_check that referenced this issue Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant