use install- features instead of package module #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grisumbras
force-pushed
the
use-install-features
branch
3 times, most recently
from
b7cf99d
to
dbef53f
Compare
grisumbras
force-pushed
the
use-install-features
branch
from
dbef53f
to
fa98e51
Compare
|
Update: bfgroup/b2#392 makes |
|
Related issues: #34, #46. Both should be fixed if this and boostorg/headers#1 are merged. |
|
#32: while writing this PR I also wondered why DLLs aren't installed into bindir. |
|
They are, but only on Cygwin for some reason. Is this ready to merge at this point, replicating the old behavior 1:1? |
|
Should be. It does work on my machine ™️ |
|
To move DLLs into bindir, we'll probably have to introduce dlldir so that people have a way to get the old behavior back. |
|
|
Why did this stop working? The PR run passed. |
|
Maybe I needed to merge the headers PR as well? |
|
The headers PR shouldn't be necessary. I'll re-push and check. |
|
Ok, something else definitely broke. I'll investigate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The core of this change is swithcing from using the
packagemodule toinstall-features. This potentially allows property-set-based install prefixes and proper staging. In addition, there's some simplification done by switching fromgeneratetargets tomaketargets. Also, all helper features are removed and<flags>is used instead.PS-based installation and proper staging doesn't work yet because
/boost/headers//installdoesn't useinstall-features.One note: most
install-Xfeatures don't check corresponding--Xoptions. Onlyinstall-prefixdoes. This is probably an oversight, so I should change that in b2 project.