Add algorithm and test for stable_partition #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good! One minor issue though, can you change the commit message to wrap at 60-70 columns? Long lines in commit messages make it harder to look through the logs in a smaller terminal. After that it should be good to merge. |
Added algorithm and test for stable_partition. Changed partition to use it for now till a better implementation is found
|
Done! |
kylelutz
added a commit
that referenced
this pull request
May 24, 2014
Add algorithm and test for stable_partition
|
Thanks! Merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added algorithm and test for
stable_partitionand changedpartitionto use it for now. I am searching for a good implementation(swaps based?) forpartitionto take advantage of the fact that order of elements need not be preserved.