Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nth element #208

Closed
wants to merge 2 commits into from
Closed

Nth element #208

wants to merge 2 commits into from

Conversation

roshanr95
Copy link
Contributor

Added benchmark, modified the tests and implemented a selection algorithm. ~5x improvement...

@roshanr95
Copy link
Contributor Author

btw I tried to do something similar to sort using boost::compute::less instead of repeating the same code twice, but ended up with a huge error: https://gist.github.com/roshanr95/b3bb5bd5e3eb16617fa6. Think it has something to do with the bind function...

I'll update it once I find a fix...

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) when pulling d898dc3 on roshanr95:nth-element into 8a11a32 on kylelutz:master.

#include <boost/compute/algorithm/sort.hpp>
#include <boost/compute/detail/read_write_single_value.hpp>
#include <boost/compute/detail/print_range.hpp>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unused include?

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) when pulling 30082ab on roshanr95:nth-element into a4a52ca on kylelutz:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) when pulling 30082ab on roshanr95:nth-element into a4a52ca on kylelutz:master.

@roshanr95
Copy link
Contributor Author

Just noticed that the pull is against master, I'll open a new one against develop...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants