Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wanted: Workaround for deduction guide detection on gcc #279

Closed
HDembinski opened this issue Apr 19, 2019 · 2 comments
Closed

Wanted: Workaround for deduction guide detection on gcc #279

HDembinski opened this issue Apr 19, 2019 · 2 comments

Comments

@HDembinski
Copy link
Contributor

HDembinski commented Apr 19, 2019

gcc-7 and gcc-8 both fail the deduction guide detection check.
gcc-7 (Ubuntu 7.3.0-27ubuntu1~18.04) 7.3.0
gcc-8 (Ubuntu 8.2.0-1ubuntu2~18.04) 8.2.0

g++-7 -std=c++17 ../config/checks/std/cpp_deduction_guides_17.cpp 
../config/checks/std/cpp_deduction_guides_17.cpp:23:2: error: #error "Macro __cpp_deduction_guides had too low a value"
 #error "Macro __cpp_deduction_guides had too low a value"
g++-8 -std=c++17 ../config/checks/std/cpp_deduction_guides_17.cpp 
../config/checks/std/cpp_deduction_guides_17.cpp:23:2: error: #error "Macro __cpp_deduction_guides had too low a value"
 #error "Macro __cpp_deduction_guides had too low a value"

These compilers support deduction guides, but the value for __cpp_deduction_guides is 201606 or 201611, respectively.
https://gcc.gnu.org/projects/cxx-status.html#cxx17

Perhaps the threshold value can be lowered to 201611?

@jzmaddock
Copy link
Collaborator

Done, I'm a bit concerned that there are corner cases that the lower threshold won't handle, but we'll see.

@HDembinski
Copy link
Contributor Author

I hope it is going to be ok, thank you for merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants