Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make std lib detection a bit more lightweight #40

Closed
wants to merge 1 commit into from
Closed

Make std lib detection a bit more lightweight #40

wants to merge 1 commit into from

Conversation

igaztanaga
Copy link
Member

...on environments where cstddef is enough to detect BOOST_STDLIB_CONFIG. Backup to <utility> (which has become heavier in C++11, as it needs traits for move_if_noexcept..) if std lib has not been detected.

The patch splits the detection in an auxiliary header and includes it twice in case cstddef is not enough.

…stddef is enough to detect BOOST_STDLIB_CONFIG. Backup to <utility> (which has become heavier in C++11) if std lib has not been detected.
@jzmaddock
Copy link
Collaborator

My only concern about this is that we might not correctly detect replacement libraries - for example STLPort or libc++ which are sitting on top of something else - by which I mean if including doesn't detect STLPort (for example) but does detect the underlying library then we go badly wrong.

@igaztanaga
Copy link
Member Author

Currently STLport is detected only including cstddef so the patch does not change this detection. libc++'s initial SVN import:

http://llvm.org/viewvc/llvm-project/libcxx/trunk/include/cstddef?revision=103490&view=markup

shows that <__config> is included and it should be detected by the patch.

I can't speak for other STLs.

jzmaddock pushed a commit that referenced this pull request Oct 2, 2014
@jzmaddock
Copy link
Collaborator

OK, I applied a slightly different fix d978d31

@jzmaddock jzmaddock closed this Oct 2, 2014
@igaztanaga
Copy link
Member Author

Great. Thanks John!

@jzmaddock
Copy link
Collaborator

Update, issue: #58 reintroduces a dependency on and we're trying to figure out what to do about it :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants