Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

With heterogeneous lookup, equal_range can result in a range with length greater than 1. #123

Merged
merged 7 commits into from Jun 22, 2019
Merged

With heterogeneous lookup, equal_range can result in a range with length greater than 1. #123

merged 7 commits into from Jun 22, 2019

Conversation

JanEisenhauer
Copy link
Contributor

Do we need tests?

@igaztanaga
Copy link
Member

Can you please add a small test case that reproduces the reported error? Thanks

@JanEisenhauer
Copy link
Contributor Author

Is it acceptable to have the struct with_lookup_by_first in both flat_set_test.cpp and flat_map_test.cpp?

@igaztanaga
Copy link
Member

Many thanks, it seems that "count()" has the same problem. I'll apply a fix on top of your patch.

@igaztanaga igaztanaga merged commit 3f09061 into boostorg:develop Jun 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JanEisenhauer @igaztanaga