Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mips64/n64: .align 3 #132

Merged
merged 1 commit into from
Dec 26, 2019
Merged

mips64/n64: .align 3 #132

merged 1 commit into from
Dec 26, 2019

Conversation

wzssyqa
Copy link
Contributor

@wzssyqa wzssyqa commented Dec 18, 2019

The right align for mips64/n64 is 3 instead of 2.

The right align for mips64/n64 is 3 instead of 2.
@olk
Copy link
Member

olk commented Dec 18, 2019

Does it pass the unit tests?

@wzssyqa
Copy link
Contributor Author

wzssyqa commented Dec 19, 2019

Does it pass the unit tests?

Yes. set .aligen here seem have no effect at all.
Nothing happens after the change value: the unit test have the same result as before.
Anyway, 3 is the right value.

@FlyGoat
Copy link
Contributor

FlyGoat commented Dec 19, 2019

It was my mistake, although it didn't cause any problem.
Variable should be aligned to 64bit boundary here in 64bit architecture.
Thanks for fixing.

@olk olk merged commit 7ada7aa into boostorg:develop Dec 26, 2019
@olk
Copy link
Member

olk commented Dec 26, 2019

Ty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants