Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Appveyor CI support #52

Merged
merged 1 commit into from
Dec 22, 2017
Merged

Add Appveyor CI support #52

merged 1 commit into from
Dec 22, 2017

Conversation

jeking3
Copy link
Contributor

@jeking3 jeking3 commented Dec 21, 2017

Results (with all test enabled): https://ci.appveyor.com/project/jeking3/date-time/build/1.0.2-develop

Wow, Trac has 149 open issues for date_time...

@eldiener eldiener merged commit 78e7772 into boostorg:develop Dec 22, 2017
@jeking3 jeking3 deleted the appveyor branch December 22, 2017 15:00
@jeking3
Copy link
Contributor Author

jeking3 commented Dec 22, 2017

Will you set up an appveyor account for this repository? The way appveyor handles it seems pretty strange, and I don't know if the account is tied to boostorg or to the individual who sets it up as a repository admin.
If you don't want to manage it, I can do it, but I would need to request maintainer status to do it, which I suppose I could do since format and uuid are in order. :)

@eldiener
Copy link
Contributor

I was able to add date_time to Appveyor. It shows up under my Appveyor account.

@jeking3
Copy link
Contributor Author

jeking3 commented Dec 22, 2017

I don't see it kicking off a build: #57

@eldiener
Copy link
Contributor

It shows up under my appveyor account that it did and was successful.

@jeking3
Copy link
Contributor Author

jeking3 commented Dec 24, 2017

You want to enable the boostorg/date_time under your account, not eldiener/date_time. I still don't see them running on pull requests, for example from yesterday: #58

@eldiener
Copy link
Contributor

All I know is that when I bring up Appveyor with my account login I see date_time because I added it. I am not sure what you mean by "your account" versus eldiener/date_time.

@jeking3
Copy link
Contributor Author

jeking3 commented Dec 25, 2017

It's the difference between adding your personal fork or the boostorg fork.

@eldiener
Copy link
Contributor

eldiener commented Dec 25, 2017

I added the boost version of date_time to the Appveyor tests. All tests I have added to Appveyor under my login to Appveyor are of Boost libraries. Why am I supposed to fork a library and add it to Appveyor ? Am I supposed to login to Appveyor under some sort of Boost account ? If so how do I do that ?

@jeking3
Copy link
Contributor Author

jeking3 commented Dec 25, 2017

If you have admin access to the boostorg/date_time repository, it should show up in your appveyor account.. it'll look like this (sorry for the resolution, my laptop screen is 4KUHD):
image

@eldiener
Copy link
Contributor

It shows up in my Appveyor account as another project which is run whenever date_time on Github gets updated. I do not see the Boostorg icon you are showing above. I just see a list of projects. All the projects listed are for the public Boostorg version of a library on Github and not for any of my own personal libraries on Github. Maybe I am supposed to sign on to Appveyor using some sort of Boostorg sign on but I do not know what that is.

@jeking3
Copy link
Contributor Author

jeking3 commented Dec 25, 2017

I think someone needs to add you as an admin on that repository in order to see it.

@eldiener
Copy link
Contributor

I can see it fine when I am logged in to Appveyor. I do not understand what you are saying. You seem to think I have do something so that you know the result of the Appveyor run, but I do not know what I am supposed to do since I can see the result whenever I go to my Appveyor account online.

@jeking3
Copy link
Contributor Author

jeking3 commented Dec 25, 2017

Since you don't see date_time under "boostorg" then you are probably just getting branch update builds on your fork.

@eldiener
Copy link
Contributor

I already told you that I do not have a fork of date_time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants