Improve CI build environment with code coverage, static analysis, valgrind #72
Conversation
| - os: linux | ||
| env: | ||
| - COMMENT="C++03" | ||
| - TOOLSET=gcc,gcc-7 |
There was a problem hiding this comment.
g++ 7 is -std=gnu++14 by default if you don't pass anything; if you really want c++03, need cxxstd=03.
There was a problem hiding this comment.
Just saw that you're setting it to 03 in ci/build.sh if not set; you can ignore that then :-) although I'd still use CXXSTD: 03 here. Testing without -std= set is a legitimate scenario that you might wish to enable.
There was a problem hiding this comment.
This is handled in the ci/build.sh script.
CXXSTD=03 is used if not set otherwise for this particular repo.
.travis.yml
Outdated
| - COMMENT=UBSAN | ||
| - B2_VARIANT=variant=debug | ||
| - TOOLSET=gcc-7 | ||
| - CXXFLAGS="cxxflags=-fno-omit-frame-pointer cxxflags=-fsanitize=undefined" |
There was a problem hiding this comment.
You have to use -fno-sanitize-recover=undefined here; without it, the sanitizer prints messages to stderr, but the test passes and nobody's any the wiser. :-)
There was a problem hiding this comment.
Thanks! I will change this too.
There was a problem hiding this comment.
@pdimov thanks for catching this; I applied it to the other repositories where I run UBSAN and it uncovered something in serialization, and as you can see in the failed build uncovered a few things in DateTime too.
jeking3
force-pushed
the
add-codecov-io
branch
5 times, most recently
from
b5ee2d5
to
a321930
Compare
…travis to use jobs
jeking3
force-pushed
the
add-codecov-io
branch
from
a321930
to
7512833
Compare
Codecov Report
@@ Coverage Diff @@
## develop #72 +/- ##
==========================================
Coverage ? 93.71%
==========================================
Files ? 80
Lines ? 5015
Branches ? 0
==========================================
Hits ? 4700
Misses ? 315
Partials ? 0Continue to review full report at Codecov.
|
Adds the following to the CI build environment: