Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSVC hardware-assisted popcount implementation #36

Closed
jeking3 opened this issue Feb 21, 2019 · 0 comments · Fixed by #38
Closed

MSVC hardware-assisted popcount implementation #36

jeking3 opened this issue Feb 21, 2019 · 0 comments · Fixed by #38

Comments

@jeking3
Copy link
Contributor

jeking3 commented Feb 21, 2019

In #25 support was added for hardware-assisted popcount.
In #33 it was noted that the implementation for MSVC failed to check for CPU support, and the MSVC documentation states the behavior is undefined in this case.
In #35 the MSVC implementation was disabled to resolve #33, which leaves the library performance in this respect the same as it was in 1.68.0.

This issue is a placeholder to come back around and clean up the implementation so it can leverage hardware assist safely with MSVC. There are some thoughts in the comments for #33 regarding alternate implementations that are useful when making a decision here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant