Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable hardware supported popcount on MSVC #35

Merged
merged 1 commit into from Feb 22, 2019

Conversation

Projects
None yet
3 participants
@jeking3
Copy link
Collaborator

jeking3 commented Feb 21, 2019

  • the new implementation failed to check for hardware support
  • the behavior was undefined on platforms without SSE4

This fixes #33

I will open another issue regarding proper implementation for MSVC.

@jeking3 jeking3 added the bug label Feb 21, 2019

@jeking3 jeking3 self-assigned this Feb 21, 2019

@jeking3 jeking3 requested review from glenfe and pdimov Feb 21, 2019

@jeking3 jeking3 added this to the v1.70.0 milestone Feb 21, 2019

/*
per https://github.com/boostorg/dynamic_bitset/issues/33
this code does not support older cpus properly...
it needs to check for cpuid support

This comment has been minimized.

@pdimov

This comment has been minimized.

@jeking3

jeking3 Feb 21, 2019

Author Collaborator

Ick. My windows editor was MSVC... see what it did? I bet there's a GitHub PR hook that checks for stuff like that... perhaps "mergeable" can do that...

Disable hardware supported popcount on MSVC.
- the new implementation failed to check for hardware support
- the behavior was undefined on platforms without SSE4

@jeking3 jeking3 force-pushed the jeking3:issue-33 branch from ffc9002 to 8b87ff2 Feb 21, 2019

@glenfe

glenfe approved these changes Feb 21, 2019

@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 21, 2019

Codecov Report

Merging #35 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop      #35   +/-   ##
========================================
  Coverage    77.15%   77.15%           
========================================
  Files            5        5           
  Lines          604      604           
  Branches       211      211           
========================================
  Hits           466      466           
  Misses          24       24           
  Partials       114      114
Impacted Files Coverage Δ
...ude/boost/dynamic_bitset/detail/dynamic_bitset.hpp 93.54% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a580c49...8b87ff2. Read the comment docs.

@jeking3 jeking3 merged commit 91625ce into boostorg:develop Feb 22, 2019

4 checks passed

codecov/patch Coverage not affected when comparing a580c49...8b87ff2
Details
codecov/project 77.15% remains the same compared to a580c49
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jeking3 jeking3 deleted the jeking3:issue-33 branch Feb 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.