Disable hardware supported popcount on MSVC #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdimov
reviewed
Feb 21, 2019
| /* | ||
| per https://github.com/boostorg/dynamic_bitset/issues/33 | ||
| this code does not support older cpus properly... | ||
| it needs to check for cpuid support |
There was a problem hiding this comment.
Ick. My windows editor was MSVC... see what it did? I bet there's a GitHub PR hook that checks for stuff like that... perhaps "mergeable" can do that...
- the new implementation failed to check for hardware support - the behavior was undefined on platforms without SSE4
glenfe
approved these changes
Feb 21, 2019
Codecov Report
@@ Coverage Diff @@
## develop #35 +/- ##
========================================
Coverage 77.15% 77.15%
========================================
Files 5 5
Lines 604 604
Branches 211 211
========================================
Hits 466 466
Misses 24 24
Partials 114 114
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #33
I will open another issue regarding proper implementation for MSVC.