-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added at(size_type) #64
Conversation
I see no tests. |
Sorry, I have added tests now. |
Codecov Report
@@ Coverage Diff @@
## develop #64 +/- ##
===========================================
+ Coverage 95.78% 95.80% +0.02%
===========================================
Files 5 5
Lines 664 668 +4
===========================================
+ Hits 636 640 +4
Misses 28 28
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still missing a negative test (see codecov's analysis in "Files changed" tab).
I suspect there may be a good reason why the reference return comes before the bool return in the definitions of operator [], so I would recommend using the same ordering for the at() method. It's also possible I'm just being a little paranoid. :) |
OK, I have changed the order of at(). |
@mclow this looks good to me, would you like to review it again? |
I'm so sorry that I want to add this member to facilitate debugging, and this member is required according to the C++ Core Guides. Thank you!