Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added at(size_type) #64

Merged
merged 5 commits into from
May 3, 2022
Merged

Added at(size_type) #64

merged 5 commits into from
May 3, 2022

Conversation

akr-akari
Copy link
Contributor

I'm so sorry that I want to add this member to facilitate debugging, and this member is required according to the C++ Core Guides. Thank you!

@mclow
Copy link
Contributor

mclow commented Apr 22, 2022

I see no tests.

@akr-akari
Copy link
Contributor Author

I see no tests.

Sorry, I have added tests now.

@codecov
Copy link

codecov bot commented Apr 27, 2022

Codecov Report

Merging #64 (b3d14a2) into develop (eb3f180) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #64      +/-   ##
===========================================
+ Coverage    95.78%   95.80%   +0.02%     
===========================================
  Files            5        5              
  Lines          664      668       +4     
===========================================
+ Hits           636      640       +4     
  Misses          28       28              
Impacted Files Coverage Δ
include/boost/dynamic_bitset/dynamic_bitset.hpp 95.49% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb3f180...b3d14a2. Read the comment docs.

Copy link
Contributor

@jeking3 jeking3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still missing a negative test (see codecov's analysis in "Files changed" tab).

@jeking3 jeking3 self-requested a review April 27, 2022 13:22
@jeking3
Copy link
Contributor

jeking3 commented Apr 27, 2022

I suspect there may be a good reason why the reference return comes before the bool return in the definitions of operator [], so I would recommend using the same ordering for the at() method. It's also possible I'm just being a little paranoid. :)

@akr-akari
Copy link
Contributor Author

OK, I have changed the order of at().

@jeking3
Copy link
Contributor

jeking3 commented Apr 29, 2022

@mclow this looks good to me, would you like to review it again?

@jeking3 jeking3 self-requested a review April 29, 2022 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants