Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

incorrect std::memory_order value in compare_exchange_strong? #126

Closed
nenomius opened this issue May 21, 2017 · 1 comment
Closed

incorrect std::memory_order value in compare_exchange_strong? #126

nenomius opened this issue May 21, 2017 · 1 comment

Comments

@nenomius
Copy link

nenomius commented May 21, 2017 •
edited

detail/spinlock_ttas_adaptive_futex.hpp#L69
detail/spinlock_ttas_futex.hpp#L65
unbuffered_channel.hpp#L242
unbuffered_channel.hpp#L292
unbuffered_channel.hpp#L74
unbuffered_channel.hpp#L89

http://en.cppreference.com/w/cpp/atomic/atomic/compare_exchange

failure - the memory synchronization ordering for the load operation if the comparison fails. Cannot be std::memory_order_release or std::memory_order_acq_rel [and cannot specify stronger ordering than success (until C++17)]
@olk
Copy link
Member

olk commented May 26, 2017

unbuffered_channel is correct - only the spinlocks have to be corrected

@olk olk closed this as completed May 26, 2017
olk added a commit that referenced this issue May 26, 2017
@olk
spinlock: failure memory order for failure must not be release
ad0321b 
- fix for #126
olk added a commit that referenced this issue May 26, 2017
@olk
spinlock: memory order for failure must not be release
18f8a9a 
- fix for #126
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@olk @nenomius