-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix fibers::asio::round_robin's notify() method. #101
Conversation
Implementation of has already changed, see branch develop |
In develop, notify() simply set the timer to expires, and it seems its not enough. |
you are right - Nat and I tried to get asio::round_robin working with multiple threads running io_service::run() of one instance of io_service. Unfortunately io_service it didn't work and not all changes were rolled back. |
merge must be into branch develop first - please change your pull request or tell me if I should do it (format-patch etc). |
I changed the base on github, but it looks like it did something ugly. Feel free to close the PR and cherry-pick the commit or something if that keeps history cleaner. Bear in mind that while this change seems to positively affect the example from #100 I think I'm still observing suspicious behavior when running my real program through valgrind. (with the use case being 2 io_service on 2 thread). My name's Arnaud Kapp. |
The notify() method of fibers::asio::round_robin doesn't give a chance to pending fibers to run. See boostorg#100 for more detail.
Arnaud, regarding to valgrind please apply valgrind=on at cmd-line. |
pushed to branch develop |
Thanks. WRT valgrind, I already use |
The notify() method of fibers::asio::round_robin doesn't give
a chance to pending fibers to run.
See #100 for more detail.