cpu_relax: fixup MIPS check for 64-bit #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out that this is also broken on mips64el. Further testing reveals that -mips32r2 -mtune=mips32r2 -mabi=32 compiles the PAUSE instruction just fine whereas -mips64r2 -mtune=mips64r2 -mabi=64 does not. The PAUSE instruction was introduced in version 2.6 of the MIPS ISA and GCC for some reason does not allow usage of it with MIPS64. Modify the macro to fix the situation instead of just matching on octeon, which is not quite correct.
|
ty |
ClaymorePT
added a commit
to ClaymorePT/packages
that referenced
this pull request
Apr 20, 2021
This commit updates boost to version 1.76.0 There are no new libraries in this version More info about Boost 1.76.0 can be found at the usual place [1]. Note: This package update includes a fix merged to Boost.Fiber in [2] which did not make into this version but it will be present in the next one. For now, the patch is needed, but it will be removed in version 1.77.0 [1]: https://www.boost.org/users/history/version_1_76_0.html [2]: boostorg/fiber#276 Signed-off-by: Carlos Miguel Ferreira <carlosmf.pt@gmail.com>
ClaymorePT
added a commit
to ClaymorePT/packages
that referenced
this pull request
Apr 20, 2021
This commit updates boost to version 1.76.0 There are no new libraries in this version More info about Boost 1.76.0 can be found at the usual place [1]. Note: This package update includes a fix merged to Boost.Fiber in [2] which did not make into this version but it will be present in the next one. For now, the patch is needed, but it will be removed in version 1.77.0 [1]: https://www.boost.org/users/history/version_1_76_0.html [2]: boostorg/fiber#276 Signed-off-by: Carlos Miguel Ferreira <carlosmf.pt@gmail.com>
ClaymorePT
added a commit
to ClaymorePT/packages
that referenced
this pull request
Apr 20, 2021
This commit updates boost to version 1.76.0 There are no new libraries in this version More info about Boost 1.76.0 can be found at the usual place [1]. Note: This package update includes a fix merged to Boost.Fiber in [2] which did not make into this version but it will be present in the next one. For now, the patch is needed, but it will be removed in version 1.77.0 [1]: https://www.boost.org/users/history/version_1_76_0.html [2]: boostorg/fiber#276 Signed-off-by: Carlos Miguel Ferreira <carlosmf.pt@gmail.com>
1715173329
pushed a commit
to immortalwrt/packages
that referenced
this pull request
Apr 21, 2021
This commit updates boost to version 1.76.0 There are no new libraries in this version More info about Boost 1.76.0 can be found at the usual place [1]. Note: This package update includes a fix merged to Boost.Fiber in [2] which did not make into this version but it will be present in the next one. For now, the patch is needed, but it will be removed in version 1.77.0 [1]: https://www.boost.org/users/history/version_1_76_0.html [2]: boostorg/fiber#276 Signed-off-by: Carlos Miguel Ferreira <carlosmf.pt@gmail.com> Signed-off-by: Tianling Shen <cnsztl@immortalwrt.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that this is also broken on mips64el. Further testing
reveals that
-mips32r2 -mtune=mips32r2 -mabi=32
compiles the PAUSE instruction just fine whereas
-mips64r2 -mtune=mips64r2 -mabi=64
does not. The PAUSE instruction was introduced in version 2.6 of the
MIPS ISA and GCC for some reason does not allow usage of it with MIPS64.
Modify the macro to fix the situation instead of just matching on
octeon, which is not quite correct.