Implement C++11 variadic templates based fusion::tuple. #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| template <typename ...T> | ||
| struct tuple : vector<T...> | ||
| { |
There was a problem hiding this comment.
Shouldn't this simply be a alias template?
There was a problem hiding this comment.
Alias templates are not always supported when variadics are, but even if they were these types are documented as different things, and making them the same could/would be problematic for partial specializations.
Furthermore, there's the question of how much should fusion::tuple try to be like std::tuple, specially considering fusion::tuple started as a TR1 implementation of tuple. Otherwise, there might not be much sense in keeping this around.
There was a problem hiding this comment.
Good points. I think the last point makes sense "there might not be much sense in keeping this around". But let's keep it for now.
djowel
added a commit
that referenced
this pull request
Aug 27, 2015
Implement C++11 variadic templates based fusion::tuple.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is last container update for support variadics.