Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow incomplete types in fusion::tag_of and fusion::is_native_fusion_sequence #171

Merged
merged 1 commit into from
Mar 3, 2018

Conversation

ldionne
Copy link
Member

@ldionne ldionne commented Mar 1, 2018

Fixes #170

Please merge this before the 1.67.0 release, as this is a regression.

Copy link
Collaborator

@Flast Flast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please confirm usage on hana, #170 (comment)

@Flast
Copy link
Collaborator

Flast commented Mar 2, 2018

@ldionne can you add a patch for fusion::is_sequence?

@ldionne
Copy link
Member Author

ldionne commented Mar 2, 2018

is_sequence does not suffer from the same problem:

template <typename T>
struct is_sequence
  : mpl::bool_<
        (bool)extension::is_sequence_impl<
            typename fusion::detail::tag_of<T>::type
        >::template apply<T>::type::value
    >
{};

If T is incomplete, tag_of will do the right thing and return something like non_fusion_tag. However, is_native_fusion_sequence appears to suffer from the same problem, so I'll patch this one too.

@ldionne ldionne changed the title Allow incomplete types in fusion::tag_of Allow incomplete types in fusion::tag_of and fusion::is_native_fusion_sequence Mar 2, 2018
Copy link
Collaborator

@Flast Flast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is_sequence does not suffer from the same problem:

You're right.

@Flast Flast merged commit 101a056 into boostorg:develop Mar 3, 2018
@Flast
Copy link
Collaborator

Flast commented Mar 3, 2018

Thanks!

@djowel
Copy link
Member

djowel commented Mar 3, 2018

Thanks @ldionne

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants