Drop dependencies, replace boost with std, remove includes #1140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barendgehrels
approved these changes
Apr 23, 2023
tinko92
reviewed
Apr 24, 2023
| @@ -12,8 +14,6 @@ | |||
|
|
|||
| #include <algorithm> | |||
There was a problem hiding this comment.
Is this include possibly unused too?
There was a problem hiding this comment.
Yes, and several others in this file. They were probably copied from spherical version. I'll remove them.
|
@barendgehrels I didn't remember that we do this. Certainly this would make cherry-picking easier into master. I'll separate the PR into two commits. |
awulkiew
force-pushed
the
feature/dependencies
branch
from
c75caac
to
3414e0b
Compare
Drop Boost.SmartPtr dependency Drop Boost.Utility (Call Traits) dependency Replace boost::array with std::array Replace boost::minmax_element with std::minmax_element Remove unneeded headers of Boost.Tuple and Boost.Algorithm Include specific headers from Boost.StringAlgo and Boost.Thread Use auto for iterator types
awulkiew
force-pushed
the
feature/dependencies
branch
from
3414e0b
to
6cca709
Compare
|
@vissarion are you ok with these changes? |
vissarion
approved these changes
May 9, 2023
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop Boost.SmartPtr dependency
Drop Boost.Utility (Call Traits) dependency
Replace
boost::arraywithstd::arrayReplace
boost::minmax_elementwithstd::minmax_elementRemove unneeded headers of Boost.Tuple and Boost.Algorithm Include specific headers from Boost.StringAlgo and Boost.ThreadUse auto for iterator types