New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Box-segment distance for spherical and geographic coordinate systems #478
Merged
Merged
Changes from 33 commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
1451bea
[strategies] [algorithms] Add support for geographic box-sgmt distance
vissarion 2acdbf7
[strategies] Fix meridian case bug for pt-sgmt geo distance
vissarion 5a0cfff
[algorithms] [envelope] Add meridian segment case
vissarion ea181b4
[algorithms] [strategies] [tests] Fix meridian distance point to meri…
vissarion 27d8955
[algorithms] Some solution for correcting distance seg-box for spheri…
vissarion 0fb5cab
[algorithms] Fix box/segment distance for segment bottom of box
vissarion a51b2dd
[algorithm] [test] Meridian case for segment box distance; segments l…
vissarion 57b9cd0
[algorithms] [tests] Fix distance segment-box for spehrical and geogr…
vissarion b485646
[algorithms] [tests] Generic box-segment distance for both cartesian …
vissarion c416382
[formulas] [tests] Handle cases of geometries in both hemispheres
vissarion e6e1b1d
[tests] Crossing prime meridian tests
vissarion 821bb37
[algorithms] [strategies] Fix issue with envelope segment algorithm; …
vissarion 2b5fc9a
Merge remote-tracking branch 'origin/develop' into feature_box_seg
vissarion d6569be
Update include files for srs.hpp
vissarion 3887cee
[tests] South hemispahre box-box tests
vissarion 37c78ac
[strategies] [tests] Diagonal case fix for box-box distance
vissarion 51a3a6b
Merge branch 'feature_box_box_fix' into feature_box_seg
vissarion 350836f
Merge with develop branch
vissarion 1e41a4d
[strategies] [tests] Fix pt-seg distance cases for south hemisphere
vissarion 93bd850
[strategies] [algorithms] Azimuth strategy and box mirror function in…
vissarion aee17ee
[strategies] [tests] Activating some tests for pt-seg distance with t…
vissarion 1484a0e
[strategies] [tests] Fix special case for geo pt-seg distance
vissarion 26fb76c
[algorithms] [distance] Optimize segment check below of box
vissarion 7f5236b
[algorithms] [distance] Use the whole segment instead of starting poi…
vissarion 18f1394
[alsorithms] [distance] Optimization: avoid to compute vertex twice i…
vissarion 8c09769
[algorithms] [strategies] In check segment below box function move CS…
vissarion e4dcc5b
[strategies] Use general units for box in segment_below_of_box strategy
vissarion 077653f
[algorithms] [strategies] Move mirror box functionality to strategies
vissarion e4f55ea
[algorithms] [distance] Clean and optimize seg on the right of box di…
vissarion 3f2660d
[tests] Remove unused strategy pt-box definitions
vissarion 72019d5
[algorithms] [strategies] Rename meridian method to vertical_or_meridian
vissarion 2583dec
[algorithms] [tests] Use azimuth side formula in disjoint
vissarion 4c63f40
[strategies] Remove default values from functional templates
vissarion 2c72e1d
[algorithms] [strategies] Change int return values with enums in disj…
vissarion fb7da10
[algorithms] [strategies] Change azimuth strategy interface
vissarion 4f755af
[algorithms] [strategies] [tests] Create unique segment-box distance …
vissarion a54ac78
[strategies] [distance] Move vertical_or_meridian method from pt-pt t…
vissarion 4a237e6
[strategies] [distance] Remove pt-pt distance strategy getters from p…
vissarion c1dd927
Fix conflicts by merging to develop
vissarion File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
enum would be safer here, or taking output value of
bool&
as argument and return bool indicating that value was computed. Unless this integral value is used in some calculation while testing something but AFAIU it isn't.