Fix dangling reference in distance #687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awulkiew
force-pushed
the
fix/dangling_reference
branch
from
7dc5448
to
bf7ca7c
Compare
mloskot
reviewed
Mar 25, 2020
| @@ -1,6 +1,6 @@ | |||
| // Boost.Geometry (aka GGL, Generic Geometry Library) | |||
|
|
|||
| // Copyright (c) 2014, 2019, Oracle and/or its affiliates. | |||
| // Copyright (c) 2014, 2019, 2020 Oracle and/or its affiliates. | |||
There was a problem hiding this comment.
I'm curious: why not 2014-2020?
There was a problem hiding this comment.
We have this policy about copyrights to put all of the dates in the message. Or at least I think we have. However I choose to drop it as soon as the line becomes too long. So I guess I may not wait until then and change it now if you like.
There was a problem hiding this comment.
Yes, I've been interpreting the policy in such way that it considers 1,2,3 and 1-3 as equivalents.
mloskot
approved these changes
Mar 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.