[distance] Add support for DG/GC in distance(). #922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vissarion
approved these changes
Oct 13, 2021
| }, it->second); | ||
|
|
||
| // The smallest possible distance found, end searching. | ||
| if (! is_first && result <= zero) |
There was a problem hiding this comment.
is it possible that result is negative?
There was a problem hiding this comment.
Technically it is, a (potentially user-defined) strategy can return any value. Possible reason may be an error or floating-point issue.
barendgehrels
approved these changes
Oct 13, 2021
| box2_t b2 = geometry::return_envelope<box2_t>(g2, strategies); | ||
| geometry::detail::expand_by_epsilon(b2); | ||
|
|
||
| for (auto it = rtree.qbegin(index::nearest(b2, rtree.size())) ; it != rtree_qend ; ++it) |
There was a problem hiding this comment.
Minor, several lines are too long, I guess we still try to limit width up to 80 chars?
There was a problem hiding this comment.
We increased max to 100 some time ago. From Guidelines-for-Developers:
- The preferred line length is 80 characters, with maximum length of 100.
- The limit is relaxed for very long string literals (e.g. Well-Known Text with data used in tests and examples).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.