-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated unary/binary_function. #191
Conversation
BTW, I have a question about the object functions implemented in Take
Casting both
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Given
AFAIU, the fractional part remains the same and constant, regardless if present before or after the addition, until it is discarded. So, both seem to be equivalent, unless you are thinking of a different case? I think, generally, explicit conversion of operands makes the arithmetic cleaner/safer (e.g. avoids /cc @stefanseefeld p.s. Most of the times I look into the template-based arithmetic expressions in GIL, trying to analyse them in terms of conversions, promotions and ranks, I quickly get confused and lost. But, this is one of the important core topics that we need to clean up! (also to clear the flood of compilation warnings). |
Thanks for the fast reply. Actually I want to implement flatfield correction, so it's more the
But this is more tricky than I had thought! Opening a separate issue to continue discussing that. |
That case 1. is exactly the division issue I was writing about in my earlier comment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good !
@sdebionne Thank you |
std::unary_function
andstd::binary_function
are deprecated in C++11 and removed in C++17. I think they are safe to remove since C++11 is required anyway.