Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dependency on Boost.StaticAssert #207

Merged
merged 1 commit into from
Jan 11, 2019
Merged

Remove dependency on Boost.StaticAssert #207

merged 1 commit into from
Jan 11, 2019

Conversation

mloskot
Copy link
Member

@mloskot mloskot commented Jan 10, 2019 •
edited

Replaced BOOST_STATIC_ASSERT with C++11 binary static_assert(expr, msg), with empty message.

In future, this should make it possible to automatically refactor into C++17 unary static_assert(expr)
using clang-tidy and its modernize-unary-static-assert check.

References

Closes #106

Tasklist

  • Review
  • Adjust for comments
  • All CI builds and checks have passed

@mloskot mloskot added the cat/refactoring Any nonfunctional changes label Jan 10, 2019
@mloskot mloskot added this to the Boost 1.70 milestone Jan 10, 2019
@mloskot mloskot added this to To Do in C++11 Modernization via automation Jan 10, 2019
@mloskot mloskot changed the title Removing dependency on Boost.StaticAssert Remove dependency on Boost.StaticAssert Jan 10, 2019
@mloskot mloskot force-pushed the ml/remove-boost-static-assert branch from 2ba366d to 7918e5e Compare January 10, 2019 22:50
@mloskot mloskot mentioned this pull request Jan 10, 2019
Closed
@mloskot mloskot added cat/enhancement Improvements, but not fixes addressing identified bugs and removed cat/enhancement Improvements, but not fixes addressing identified bugs labels Jan 10, 2019
@mloskot
Remove dependency on Boost.StaticAssert
68fe3db 
Replaced BOOST_STATIC_ASSERT with C++11 binary static_assert,
with empty message.

In future, this should make it possible to automatically refactor
into C++17 unary static_assert using clang-tidy and
its modernize-unary-static-assert check.

Closes boostorg#106
@mloskot mloskot force-pushed the ml/remove-boost-static-assert branch from 7918e5e to 68fe3db Compare January 11, 2019 08:47
@mloskot mloskot self-assigned this Jan 11, 2019
@mloskot mloskot merged commit 6e3ccc0 into boostorg:develop Jan 11, 2019
C++11 Modernization automation moved this from To Do to Done Jan 11, 2019
@mloskot mloskot deleted the ml/remove-boost-static-assert branch January 11, 2019 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanseefeld stefanseefeld stefanseefeld approved these changes

@chhenning chhenning Awaiting requested review from chhenning

Assignees

@mloskot mloskot

Labels
cat/refactoring Any nonfunctional changes
Projects
C++11 Modernization
  
Done
Milestone
Boost 1.70
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mloskot @stefanseefeld