Replace BOOST_STATIC_CONSTANT with constexpr #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tidy up formatting of refactored parts of code.
mloskot
force-pushed
the
ml/replace-boost-constant-with-constexpr
branch
from
e51b5ab
to
81c76b1
Compare
|
@stefanseefeld CI-s are green. Shall I merge this? |
stefanseefeld
approved these changes
Jan 12, 2019
mloskot
added a commit
that referenced
this pull request
Jan 14, 2019
The constexpr belongs to the declaration specifiers (like static) and not just the type specifiers (like cv-qualifiers), so it binds to the declaration (like static), not the type (like const). Refines #211
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tidy up formatting of refactored parts of code.
Tasklist