Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use just ::value where is possible #262

Merged
merged 1 commit into from
Mar 19, 2019
Merged

Use just ::value where is possible #262

merged 1 commit into from
Mar 19, 2019

Conversation

Kojoley
Copy link
Contributor

@Kojoley Kojoley commented Mar 19, 2019 •
edited by mloskot

Fixes VS2015 failures.

Usually all boolean (like is_*, or, and) and integral (like *size*, *num*) metafunctions have value member.

References

@Kojoley
Use just ::value where is possible
37e3a0e 
Fixes VS2015 failures.
@mloskot mloskot self-requested a review March 19, 2019 18:26
mloskot
mloskot approved these changes Mar 19, 2019
View reviewed changes
Copy link
Member

@mloskot mloskot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for making the clean up!

@mloskot mloskot self-assigned this Mar 19, 2019
@mloskot mloskot added cat/refactoring Any nonfunctional changes cat/annoyance Not a bug, not a feature, but something that should be improved labels Mar 19, 2019
@mloskot mloskot mentioned this pull request Mar 19, 2019
Merged
1 task
@mloskot mloskot merged commit 33d4ac0 into boostorg:develop Mar 19, 2019
@mloskot
Copy link
Member

mloskot commented Mar 19, 2019

@Kojoley Thank you!

@stefanseefeld Should this go to Boost 1.70?

@Kojoley Kojoley deleted the redundant-type-indirection branch March 19, 2019 19:35
@mloskot mloskot mentioned this pull request Mar 19, 2019
Closed
@stefanseefeld
Copy link
Member

Given that this is merely a cosmetic fix, I don't think this qualifies.

@mloskot
Copy link
Member

mloskot commented Mar 19, 2019 •
edited

It fixes compilation for VS2015 users, doesn't it?

I don't use VS2015 myself and I don't care about it, but there are users who do, apparently.

@stefanseefeld
Copy link
Member

Oh, sorry, I had missed that. In this case it clearly does ! :-)
(But rather than cherry-picking I'd like to do another merge, but I'll ask the RM first.)

@mloskot
Copy link
Member

mloskot commented Mar 19, 2019

No problem. Good we've clarified that. Thanks

@mloskot mloskot added this to the Boost 1.70 milestone Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mloskot mloskot mloskot approved these changes

@stefanseefeld stefanseefeld stefanseefeld approved these changes

Assignees

@mloskot mloskot

Labels
cat/annoyance Not a bug, not a feature, but something that should be improved cat/refactoring Any nonfunctional changes
Projects
None yet
Milestone
Boost 1.70
Development

Successfully merging this pull request may close these issues.

With the std::enable_if the GIL library fails to compile on MSVC-14:
3 participants
@Kojoley @mloskot @stefanseefeld