Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upFix UB due is_trivially_default_constructible specializations #284
Conversation
C++11 / 20.11.2 Header <type_traits> synopsis 1 The behavior of a program that adds specializations for any of the class templates defined in this subclause is undefined unless otherwise specified. The specializations are not used anywhere, so they are safe to remove without providing a replacement. Fixes #283
without hesitation ! :-) |
This comment has been minimized.
This comment has been minimized.
All built for me locally with GCC 7.3, so I'm hopeful :) |
This comment has been minimized.
This comment has been minimized.
My private Travis for GIL is all green! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mloskot commentedApr 15, 2019
•
edited
The specializations are not used anywhere, so they are safe to remove
without providing a replacement.
References
Fixes #283
Tasklist