Skip to content

/gil

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UB due is_trivially_default_constructible specializations #284

Merged
merged 1 commit into from Apr 15, 2019
Merged

Fix UB due is_trivially_default_constructible specializations #284

merged 1 commit into from Apr 15, 2019

Conversation

@mloskot
Copy link
Member

mloskot commented Apr 15, 2019 •
edited

C++11 / 20.11.2 Header <type_traits> synopsis
1 The behavior of a program that adds specializations for any
of the class templates defined in this subclause is undefined
unless otherwise specified.

The specializations are not used anywhere, so they are safe to remove
without providing a replacement.

References

Fixes #283

Tasklist

  • Review
  • All CI builds and checks have passed
@mloskot
Fix UB due is_trivially_default_constructible specializations
Verified
This commit was signed with a verified signature.
mloskot Mateusz Łoskot
GPG key ID: 928D7C2ABB2AC1F2 Learn about signing commits
Loading status checks…
e8a9a82 
   C++11 / 20.11.2 Header <type_traits> synopsis
   1 The behavior of a program that adds specializations for any
   of the class templates defined in this subclause is undefined
   unless otherwise specified.

The specializations are not used anywhere, so they are safe to remove
without providing a replacement.

Fixes #283
@mloskot mloskot added the cat/bug label Apr 15, 2019
@mloskot mloskot requested a review from stefanseefeld Apr 15, 2019
@mloskot mloskot added this to To Do in C++11 Modernization via automation Apr 15, 2019
@mloskot mloskot mentioned this pull request Apr 15, 2019
Closed
@stefanseefeld
stefanseefeld approved these changes Apr 15, 2019
View changes
Copy link
Member

stefanseefeld left a comment

without hesitation ! :-)
@mloskot

This comment has been minimized.

Sign in to view
Copy link
Member Author

mloskot commented Apr 15, 2019

All built for me locally with GCC 7.3, so I'm hopeful :)
@mloskot

This comment has been minimized.

Sign in to view
Copy link
Member Author

mloskot commented Apr 15, 2019

My private Travis for GIL is all green!
https://travis-ci.org/mloskot/gil/builds/520437453
@mloskot mloskot self-assigned this Apr 15, 2019
@mloskot mloskot added this to the Boost 1.71 milestone Apr 15, 2019
@mloskot mloskot merged commit 555c4cc into boostorg:develop Apr 15, 2019
9 checks passed
9 checks passed
boostorg.gil Build #20190415.1 succeeded
Details
boostorg.gil (macos1013_xcode91_cmake) macos1013_xcode91_cmake succeeded
Details
boostorg.gil (ubuntu1604_gcc5_cxx11_cmake) ubuntu1604_gcc5_cxx11_cmake succeeded
Details
boostorg.gil (ubuntu1604_gcc8_cxx14_cmake) ubuntu1604_gcc8_cxx14_cmake succeeded
Details
boostorg.gil (win2012_vs2015_cmake) win2012_vs2015_cmake succeeded
Details
boostorg.gil (win2016_vs2017_cxx14_cmake) win2016_vs2017_cxx14_cmake succeeded
Details
boostorg.gil (win2016_vs2017_cxx17_cmake) win2016_vs2017_cxx17_cmake succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
C++11 Modernization automation moved this from To Do to Done Apr 15, 2019
@mloskot mloskot deleted the mloskot:ml/remove-is_trivially_default_constructible-specialization branch Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanseefeld stefanseefeld

Assignees

@mloskot mloskot

Labels
cat/bug
Projects
C++11 Modernization
  
Done
Milestone
  Boost 1.72
2 participants
@mloskot @stefanseefeld
You can’t perform that action at this time.