Flatten structure of test/extension/io/output/ folder #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no need for format-specific subfolders. There is no code in place that checks if all those folders exist and creates them. This change simplifies the structure to simplify running of I/O tests.
The `jpeg` is name of the format used in the I/O extension and the folders inside `images/` are named after those formats.
mloskot
added
ext/io
|
Travis for boostorg/gil is still pending - https://travis-ci.org/boostorg/gil/builds/604176547 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is no need for format-specific subfolders.
There is no code in place that checks if all those folders exist and creates them.
This change simplifies the structure to simplify running of I/O tests.
Rename
images/jpg/toimages/jpeg/in tests.The
jpegis name of the format used in the I/O extension and the folders insideimages/are named after those formats.This in fact fixes tests run for build with
BOOST_GIL_IO_TEST_ALLOW_READING_IMAGESandBOOST_GIL_IO_TEST_ALLOW_WRITING_IMAGESmacros defined in case theoutput/*structure is missing.Tasklist