Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AppVeyor jobs for b2 variant=release #46

Merged
merged 5 commits into from
Mar 30, 2018

Conversation

mloskot
Copy link
Member

@mloskot mloskot commented Mar 16, 2018

/cc @chhenning, @stefanseefeld yet another curious case :)

For variant-debug all tests pass - this is the default AppVeyor builds variant for current the master.

For variant=release, run for test/image.cpp will likely fail due to mismatch of CRC calculated bgr121_basic_red_x image.

mloskot added a commit to mloskot/gil that referenced this pull request Mar 18, 2018
This aims to confirm there are no issues depending
on build configuration (related to boostorg#46 and 49).
mloskot added a commit to mloskot/gil that referenced this pull request Mar 18, 2018
This aims to confirm there are no issues depending
on build configuration (related to boostorg#46 and boostorg#49).
mloskot added a commit to mloskot/gil that referenced this pull request Mar 28, 2018
This aims to confirm there are no issues depending
on build configuration (related to boostorg#46 and boostorg#49).
@mloskot
Copy link
Member Author

mloskot commented Mar 28, 2018

@stefanseefeld @chhenning I've cherry-picked the the UB fix commit cead84e into this branch.

mloskot added a commit that referenced this pull request Mar 28, 2018
Reverts commit SHA-1:e80f9d2f4b2c688b3f7a77b9845e28793e4f5d0b

Preparing to verify if fix for overflowing bit-shift operation (UB)
suggested by Andrey Semashev via Boost ML will fix the checksum bug too.
See discussions for #46 and #50 for details.
mloskot added a commit to mloskot/gil that referenced this pull request Mar 28, 2018
This aims to confirm there are no issues depending
on build configuration (related to boostorg#46 and boostorg#49).
@mloskot
Copy link
Member Author

mloskot commented Mar 28, 2018

I've reverted 9d9fc09 that temporarily disabled the failing checksum test cases and updated this PR to see if the UB fix also fixes the checksum bug #49

@mloskot
Copy link
Member Author

mloskot commented Mar 28, 2018

I've copied the fix to more places, see #68

mloskot added a commit to mloskot/gil that referenced this pull request Mar 29, 2018
This aims to confirm there are no issues depending
on build configuration (related to boostorg#46 and boostorg#49).
Log CRC that is verified for each test image by test/image.
Patch courtesy of Andrey Semashev via Boost ML.
@mloskot
Copy link
Member Author

mloskot commented Mar 30, 2018

Apparently, I have already committed variant=release for AppVeyor in e680849

I think, I assumed the b2 default variant is release, so I simply set it explicitly.

I am going to update AppVeyor configuration to bring back variant=debug build jobs.

@mloskot mloskot merged commit 8968b2c into boostorg:develop Mar 30, 2018
@mloskot mloskot deleted the ml/add-b2-variant-release branch March 30, 2018 20:27
mloskot added a commit to mloskot/gil that referenced this pull request Mar 31, 2018
This aims to confirm there are no issues depending
on build configuration (related to boostorg#46 and boostorg#49).
stefanseefeld pushed a commit that referenced this pull request Jun 27, 2018
Reverts commit SHA-1:e80f9d2f4b2c688b3f7a77b9845e28793e4f5d0b

Preparing to verify if fix for overflowing bit-shift operation (UB)
suggested by Andrey Semashev via Boost ML will fix the checksum bug too.
See discussions for #46 and #50 for details.
stefanseefeld pushed a commit that referenced this pull request Jun 27, 2018
Add AppVeyor jobs for b2 variant=release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant