Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

std::max_element requires forward iterator #190

Merged
merged 2 commits into from
Apr 21, 2021

Conversation

bkpoon
Copy link
Contributor

@bkpoon bkpoon commented Oct 16, 2019

  1. Replace std::max_element with boost::first_max_element in include/boost/graph/bc_clustering.hpp as described in std::max_element requires forward iterator #175.
  2. Additionally, include/boost/graph/howard_cycle_ratio.hpp has the same issue and is patched similarly in b9c3b14.

I ran the basic tests. Everything compiles with Xcode 11.1 running on macOS 10.14.6 and it looks like nothing failed, but I'm not sure. I did have to remove disjoint_sets.hpp from include/boost/pending and include/boost/pending/detail for b2 to work with the develop branch.

The testing is how I found the problem with include/boost/graph/howard_cycle_ratio.hpp. There is also a std::max_element in include/boost/graph/planar_detail/bucket_sort.hpp, but it looks like the arguments are acceptable iterators.

git clone https://github.com/boostorg/boost
cd boost
git submodule update --init

<change files in lib/graph>

./bootstrap.sh            <- compile b2
./b2 headers              <- just installs headers
./b2                      <- build compiled components

../../../b2               <- run all tests in lib/graph/test

Let me know if anything else is needed. Thanks!

@bkpoon bkpoon changed the base branch from master to develop October 16, 2019 22:34
@bkpoon
Copy link
Contributor Author

bkpoon commented Oct 16, 2019

I changed the base from master to develop.

@bkpoon bkpoon changed the title std::max_element requires forward iterator #175 std::max_element requires forward iterator Oct 16, 2019
@jzmaddock jzmaddock merged commit 1fd5fc1 into boostorg:develop Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants