std::max_element requires forward iterator #190
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std::max_element
withboost::first_max_element
ininclude/boost/graph/bc_clustering.hpp
as described in std::max_element requires forward iterator #175.include/boost/graph/howard_cycle_ratio.hpp
has the same issue and is patched similarly in b9c3b14.I ran the basic tests. Everything compiles with Xcode 11.1 running on macOS 10.14.6 and it looks like nothing failed, but I'm not sure. I did have to remove
disjoint_sets.hpp
frominclude/boost/pending
andinclude/boost/pending/detail
forb2
to work with thedevelop
branch.The testing is how I found the problem with
include/boost/graph/howard_cycle_ratio.hpp
. There is also astd::max_element
ininclude/boost/graph/planar_detail/bucket_sort.hpp
, but it looks like the arguments are acceptable iterators.Let me know if anything else is needed. Thanks!