Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More GCC suggest-override warnings #160

Closed
DonOregano opened this issue Nov 27, 2021 · 1 comment
Closed

More GCC suggest-override warnings #160

DonOregano opened this issue Nov 27, 2021 · 1 comment

Comments

@DonOregano
Copy link
Contributor

I had -Werror=suggest-override set when I did this, so below are errors instead of warnings.

bufferstream.hpp:118:21: error: ‘boost::interprocess::basic_bufferbuf<CharT, CharTraits>::int_type boost::interprocess::basic_bufferbuf<CharT, CharTraits>::underflow() [with CharT = char; CharTraits = std::char_traits<char>; boost::interprocess::basic_bufferbuf<CharT, CharTraits>::int_type = int]’ can be marked override [-Werror=suggest-override]
  118 |    virtual int_type underflow()
bufferstream.hpp:125:21: error: ‘boost::interprocess::basic_bufferbuf<CharT, CharTraits>::int_type boost::interprocess::basic_bufferbuf<CharT, CharTraits>::pbackfail(boost::interprocess::basic_bufferbuf<CharT, CharTraits>::int_type) [with CharT = char; CharTraits = std::char_traits<char>; boost::interprocess::basic_bufferbuf<CharT, CharTraits>::int_type = int]’ can be marked override [-Werror=suggest-override]
  125 |    virtual int_type pbackfail(int_type c = CharTraits::eof())
bufferstream.hpp:150:21: error: ‘boost::interprocess::basic_bufferbuf<CharT, CharTraits>::int_type boost::interprocess::basic_bufferbuf<CharT, CharTraits>::overflow(boost::interprocess::basic_bufferbuf<CharT, CharTraits>::int_type) [with CharT = char; CharTraits = std::char_traits<char>; boost::interprocess::basic_bufferbuf<CharT, CharTraits>::int_type = int]’ can be marked override [-Werror=suggest-override]
  150 |    virtual int_type overflow(int_type c = CharTraits::eof())
bufferstream.hpp:182:21: error: ‘boost::interprocess::basic_bufferbuf<CharT, CharTraits>::pos_type boost::interprocess::basic_bufferbuf<CharT, CharTraits>::seekoff(boost::interprocess::basic_bufferbuf<CharT, CharTraits>::off_type, std::ios_base::seekdir, std::ios_base::openmode) [with CharT = char; CharTraits = std::char_traits<char>; boost::interprocess::basic_bufferbuf<CharT, CharTraits>::pos_type = std::fpos<__mbstate_t>; boost::interprocess::basic_bufferbuf<CharT, CharTraits>::off_type = long int; std::ios_base::seekdir = std::ios_base::seekdir; std::ios_base::openmode = std::ios_base::openmode]’ can be marked override [-Werror=suggest-override]
  182 |    virtual pos_type seekoff(off_type off, std::ios_base::seekdir dir,
bufferstream.hpp:248:21: error: ‘boost::interprocess::basic_bufferbuf<CharT, CharTraits>::pos_type boost::interprocess::basic_bufferbuf<CharT, CharTraits>::seekpos(boost::interprocess::basic_bufferbuf<CharT, CharTraits>::pos_type, std::ios_base::openmode) [with CharT = char; CharTraits = std::char_traits<char>; boost::interprocess::basic_bufferbuf<CharT, CharTraits>::pos_type = std::fpos<__mbstate_t>; std::ios_base::openmode = std::ios_base::openmode]’ can be marked override [-Werror=suggest-override]
  248 |    virtual pos_type seekpos(pos_type pos, std::ios_base::openmode mode
@igaztanaga
Copy link
Member

Thanks for the report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants