Fix mingw compile error #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MinGW has nonstandard definition of PSECURITY_DESCRIPTOR, which requires a cast when calling WinAPI functions InitializeSecurityDescriptor and SetSecurityDescriptorDacl. This is done by Boost.WinAPI wrapper functions. Fixes boostorg#118.
Lastique
force-pushed
the
fix_mingw_compile_error
branch
from
cfe5c5d
to
b89b22c
Compare
|
@igaztanaga A kind reminder. This is currently causing massive Boost.Log CI failures on Windows. |
|
Many thanks for the patch and the reminder ;-) |
|
Please, remember to merge to master. |
|
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MinGW has nonstandard definition of
PSECURITY_DESCRIPTOR, which requires a cast when calling WinAPI functionsInitializeSecurityDescriptorandSetSecurityDescriptorDacl. This is done by Boost.WinAPI wrapper functions.Fixes #118.
Also, fixed the
initializedflag not being set correctly afterinterprocess_all_access_securityinitialization completes.