Fix bstree_algorithms<>::swap_nodes
#61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Many thanks for the report and the patch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The node swapping code (which is marked experimental) seems to lack special handling for the case when the nodes to be swapped are siblings (i.e., they have the same parent).
In that case, special care needs to be taken when updating the parent node as aliasing occurs in the normal code.
Run the test case from this PR against current
developto see the bug.Changes in this PR
Notes
I've tried to keep everything C++03 and the tests build with
g++ -std=c++03on my setup.I've also added (C) notices to both files; please let me know if this is in line with contribution guidelines. I'm not religious about them.