-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix processing of multi-stream files #87
Conversation
Perhaps there is a better fix but this patch fixes the problem for me. |
Two things:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could use a test with input that leverages multi-stream files.
Fixes issue #86
Codecov Report
@@ Coverage Diff @@
## develop #87 +/- ##
==========================================
- Coverage 69.04% 68.94% -0.1%
==========================================
Files 80 80
Lines 3437 3439 +2
Branches 1025 1027 +2
==========================================
- Hits 2373 2371 -2
- Misses 451 452 +1
- Partials 613 616 +3
Continue to review full report at Codecov.
|
Thank you for your feedback, @jeking3. |
Please @jeking3, could you re-review this pull request to see if the changes made are sufficient? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it now:
meet the postcondition requiring that either i1 == i2 or o1 == o2
described in the related issue.
Fixes issue #86