Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix segfault in array::erase #695

Merged
merged 1 commit into from
May 14, 2022

Conversation

grisumbras
Copy link
Member

@grisumbras grisumbras commented Apr 20, 2022

Fix #692

@codecov
Copy link

codecov bot commented Apr 20, 2022

Codecov Report

Merging #695 (c9ab3fa) into develop (8be6f6b) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head c9ab3fa differs from pull request most recent head 07e3ef1. Consider uploading reports for the commit 07e3ef1 to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #695      +/-   ##
===========================================
- Coverage    99.08%   99.08%   -0.01%     
===========================================
  Files           69       69              
  Lines         6546     6542       -4     
===========================================
- Hits          6486     6482       -4     
  Misses          60       60              
Impacted Files Coverage Δ
include/boost/json/impl/array.ipp 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8be6f6b...07e3ef1. Read the comment docs.

@cppalliance-bot
Copy link

@vinniefalco
Copy link
Member

well yeah that's another way to do it :)

Just squash this down and keep your name on it please... we dont need 2 commits for this.

@cppalliance-bot
Copy link

@grisumbras grisumbras merged commit 07e3ef1 into boostorg:develop May 14, 2022
@grisumbras grisumbras deleted the fix/erase-segfault branch May 14, 2022 15:45
ClaymorePT added a commit to ClaymorePT/packages that referenced this pull request Aug 18, 2022
This commit updates boost to version 1.80.0

There are no new libraries in this version

The following patches were removed due to upstream update:
* 010-mips1.patch [1]
* 910-json-array-erase-relocate.patch [2]

More info about Boost 1.80.0 can be found at the usual place [3].

[1]: boostorg/config#390
[2]: boostorg/json#695
[3]: https://www.boost.org/users/history/version_1_80_0.html

Signed-off-by: Carlos Miguel Ferreira <carlosmf.pt@gmail.com>
ClaymorePT added a commit to ClaymorePT/packages that referenced this pull request Aug 18, 2022
This commit updates boost to version 1.80.0

There are no new libraries in this version

The following patches were removed due to upstream update:
* 010-mips1.patch [1]
* 910-json-array-erase-relocate.patch [2]

More info about Boost 1.80.0 can be found at the usual place [3].

[1]: boostorg/config#390
[2]: boostorg/json#695
[3]: https://www.boost.org/users/history/version_1_80_0.html

Signed-off-by: Carlos Miguel Ferreira <carlosmf.pt@gmail.com>
ClaymorePT added a commit to ClaymorePT/packages that referenced this pull request Aug 18, 2022
This commit updates boost to version 1.80.0

There are no new libraries in this version

The following patches were removed due to upstream update:
* 010-mips1.patch [1]
* 910-json-array-erase-relocate.patch [2]

More info about Boost 1.80.0 can be found at the usual place [3].

[1]: boostorg/config#390
[2]: boostorg/json#695
[3]: https://www.boost.org/users/history/version_1_80_0.html

Signed-off-by: Carlos Miguel Ferreira <carlosmf.pt@gmail.com>
neheb pushed a commit to openwrt/packages that referenced this pull request Aug 19, 2022
This commit updates boost to version 1.80.0

There are no new libraries in this version

The following patches were removed due to upstream update:
* 010-mips1.patch [1]
* 910-json-array-erase-relocate.patch [2]

More info about Boost 1.80.0 can be found at the usual place [3].

[1]: boostorg/config#390
[2]: boostorg/json#695
[3]: https://www.boost.org/users/history/version_1_80_0.html

Signed-off-by: Carlos Miguel Ferreira <carlosmf.pt@gmail.com>
breakings pushed a commit to breakings/packages that referenced this pull request Aug 24, 2022
This commit updates boost to version 1.80.0

There are no new libraries in this version

The following patches were removed due to upstream update:
* 010-mips1.patch [1]
* 910-json-array-erase-relocate.patch [2]

More info about Boost 1.80.0 can be found at the usual place [3].

[1]: boostorg/config#390
[2]: boostorg/json#695
[3]: https://www.boost.org/users/history/version_1_80_0.html

Signed-off-by: Carlos Miguel Ferreira <carlosmf.pt@gmail.com>
Beginner-Go pushed a commit to coolsnowwolf/packages that referenced this pull request Aug 24, 2022
* boost: bump to version 1.80.0

This commit updates boost to version 1.80.0

There are no new libraries in this version

The following patches were removed due to upstream update:
* 010-mips1.patch [1]
* 910-json-array-erase-relocate.patch [2]

More info about Boost 1.80.0 can be found at the usual place [3].

[1]: boostorg/config#390
[2]: boostorg/json#695
[3]: https://www.boost.org/users/history/version_1_80_0.html

Signed-off-by: Carlos Miguel Ferreira <carlosmf.pt@gmail.com>

* boost: restores patch for libboost_context for mips64

This commit restores the patch for libboost_context for mips64 given
that the upstream update added in 1.80.0 does not fully fixes the issue.

Signed-off-by: Carlos Miguel Ferreira <carlosmf.pt@gmail.com>

Signed-off-by: Carlos Miguel Ferreira <carlosmf.pt@gmail.com>
Co-authored-by: Carlos Miguel Ferreira <carlosmf.pt@gmail.com>
1715173329 pushed a commit to immortalwrt/packages that referenced this pull request Aug 30, 2022
This commit updates boost to version 1.80.0

There are no new libraries in this version

The following patches were removed due to upstream update:
* 010-mips1.patch [1]
* 910-json-array-erase-relocate.patch [2]

More info about Boost 1.80.0 can be found at the usual place [3].

[1]: boostorg/config#390
[2]: boostorg/json#695
[3]: https://www.boost.org/users/history/version_1_80_0.html

Signed-off-by: Carlos Miguel Ferreira <carlosmf.pt@gmail.com>
(cherry picked from commit 97becb5)
stokito pushed a commit to stokito/packages that referenced this pull request Dec 6, 2022
This commit updates boost to version 1.80.0

There are no new libraries in this version

The following patches were removed due to upstream update:
* 010-mips1.patch [1]
* 910-json-array-erase-relocate.patch [2]

More info about Boost 1.80.0 can be found at the usual place [3].

[1]: boostorg/config#390
[2]: boostorg/json#695
[3]: https://www.boost.org/users/history/version_1_80_0.html

Signed-off-by: Carlos Miguel Ferreira <carlosmf.pt@gmail.com>
ineedfat pushed a commit to ineedfat/rockchip_rk3568_openwrt_packages that referenced this pull request Jun 7, 2024
* boost: bump to version 1.80.0

This commit updates boost to version 1.80.0

There are no new libraries in this version

The following patches were removed due to upstream update:
* 010-mips1.patch [1]
* 910-json-array-erase-relocate.patch [2]

More info about Boost 1.80.0 can be found at the usual place [3].

[1]: boostorg/config#390
[2]: boostorg/json#695
[3]: https://www.boost.org/users/history/version_1_80_0.html

Signed-off-by: Carlos Miguel Ferreira <carlosmf.pt@gmail.com>

* boost: restores patch for libboost_context for mips64

This commit restores the patch for libboost_context for mips64 given
that the upstream update added in 1.80.0 does not fully fixes the issue.

Signed-off-by: Carlos Miguel Ferreira <carlosmf.pt@gmail.com>

Signed-off-by: Carlos Miguel Ferreira <carlosmf.pt@gmail.com>
Co-authored-by: Carlos Miguel Ferreira <carlosmf.pt@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

json::array::erase(it) seg fault on linux
3 participants