Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/deduce endianness #719

Merged
merged 6 commits into from Jun 12, 2022
Merged

Conversation

grisumbras
Copy link
Member

@grisumbras grisumbras commented Jun 9, 2022

Fix #717
Also see #576

@grisumbras grisumbras force-pushed the fix/deduce-endianness branch 4 times, most recently from 9fad44e to 98228f0 Compare June 9, 2022 18:31
@cppalliance-bot
Copy link

@cppalliance-bot
Copy link

@grisumbras grisumbras force-pushed the fix/deduce-endianness branch 5 times, most recently from 66b11f6 to 78c6976 Compare June 10, 2022 10:43
@cppalliance-bot
Copy link

@grisumbras grisumbras force-pushed the fix/deduce-endianness branch 6 times, most recently from 8ad6124 to 850f33d Compare June 10, 2022 16:04
@codecov
Copy link

codecov bot commented Jun 10, 2022

Codecov Report

Merging #719 (b87b777) into develop (79700a1) will increase coverage by 0.04%.
The diff coverage is 100.00%.

❗ Current head b87b777 differs from pull request most recent head f1b9420. Consider uploading reports for the commit f1b9420 to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #719      +/-   ##
===========================================
+ Coverage    99.08%   99.13%   +0.04%     
===========================================
  Files           69       69              
  Lines         6553     6552       -1     
===========================================
+ Hits          6493     6495       +2     
+ Misses          60       57       -3     
Impacted Files Coverage Δ
include/boost/json/basic_parser_impl.hpp 99.20% <ø> (ø)
include/boost/json/detail/config.hpp 100.00% <ø> (ø)
include/boost/json/detail/sse2.hpp 97.77% <100.00%> (-0.02%) ⬇️
include/boost/json/detail/utf8.hpp 100.00% <100.00%> (+4.91%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79700a1...f1b9420. Read the comment docs.

@cppalliance-bot
Copy link

@cppalliance-bot
Copy link

@vinniefalco
Copy link
Member

Please no negative commit messages e.g. "confusing code." Instead express it as a positive "add clarifying implementation notes"

@cppalliance-bot
Copy link

@grisumbras grisumbras merged commit f1b9420 into boostorg:develop Jun 12, 2022
@grisumbras grisumbras deleted the fix/deduce-endianness branch June 12, 2022 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug on solaris
3 participants