Refactor tests and enable -Werror in CMake build #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flamefire
force-pushed
the
test_refactor
branch
from
f605f5b
to
489b9f5
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #109 +/- ##
===========================================
- Coverage 80.97% 80.69% -0.29%
===========================================
Files 76 73 -3
Lines 5891 5790 -101
===========================================
- Hits 4770 4672 -98
+ Misses 1121 1118 -3
Continue to review full report at Codecov.
|
Flamefire
force-pushed
the
test_refactor
branch
4 times, most recently
from
386bed6
to
dbe7f38
Compare
Change the Jamfile to use a format usable with `BoostTestJamfile` and then use that in the CMakeLists
C4251: "icu_50::DecimalFormat::fBoolFlags": class "icu_50::EnumSet<UNumberFormatAttribute,4096,4098>" needs to have dll-interface...
Simplify code by removing uneccessary loops. Factor out code from macros into functions to allow easier debugging.
Gets rid of the `test_` prefix in the filenames and avoids confusing those with the actual tests especially by renaming the test framework file from `test_locale.hpp` to `unit_test.hpp`
Flamefire
force-pushed
the
test_refactor
branch
2 times, most recently
from
da3ea9a
to
e4703df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
boost_test_jamfileto automatically generate tests in CMake from the Jamfile-Werrorin CMake tests and use thatTEST_EQto print values of failing equal-assertions