Refactor icu_formatters_cache and tests #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Especially the `get_icu_currency_iso` was reevaluated multiple times for each subtest which is redundant. So modify the macros to store the value as a `const std::string` evaluating it exactly once.
Use enums to access arrays.
Closed
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #115 +/- ##
========================================
Coverage 84.20% 84.20%
========================================
Files 73 73
Lines 5794 5794
========================================
Hits 4879 4879
Misses 915 915
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
format_lento be used as indices for the ICU cache replacing the magic constants.test_configtoshow_config(more appropriate name) and always show its output on CI (workaround until B2 natively supports that, CC @grafikrobot in case you want to see a use case)