Fix FreeBSD support #122
Merged
Fix FreeBSD support #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FreeBSD has a builtin iconv and an external one in /usr/local. When linking against ICU (in /usr/local) the (incompatible) headers of the external libiconv are found failing with missing symbols such as `libiconv_open`. Account for that in the CMake build. Signed-off-by: Alexander Grund <Flamefire@users.noreply.github.com>
Signed-off-by: Alexander Grund <Flamefire@users.noreply.github.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #122 +/- ##
===========================================
- Coverage 88.46% 88.45% -0.01%
===========================================
Files 100 100
Lines 8982 8977 -5
===========================================
- Hits 7946 7941 -5
Misses 1036 1036
Continue to review full report at Codecov.
|
The test tools would add duplicate definitions of POSIX functions/types when the POSIX backend is disabled. So check for that and always include the POSIX stuff where available. Signed-off-by: Alexander Grund <Flamefire@users.noreply.github.com>
A variable was erronously unused. Refactor the implementation to simplify the code. Signed-off-by: Alexander Grund <Flamefire@users.noreply.github.com>
Add token as a means to avoid upload failure, see https://github.com/codecov/codecov-action/issues/837
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly a fix for a warning and a workaround for the CMake build at least.