Fix issue with negative times in date_time and add tests for full coverage
#198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes checks for correct timezone in `date_time`
Flamefire
force-pushed
the
date_time-coverage
branch
from
08af221
to
94d8427
Compare
The fractional part (sub-seconds) was not handled correctly (subtracting the second only from a temporary) Fix this and add tests, also for comparing sub-second differences.
Flamefire
force-pushed
the
date_time-coverage
branch
from
94d8427
to
303e141
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #198 +/- ##
===========================================
+ Coverage 94.93% 95.26% +0.32%
===========================================
Files 114 114
Lines 9917 10001 +84
===========================================
+ Hits 9415 9527 +112
+ Misses 502 474 -28
Continue to review full report in Codecov by Sentry.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When handling negative times (
doublevalue) the fractional part (i.e. nanoseconds) is subtracted from the seconds to make the nanoseconds positive. However the subtraction happened on a temporary value, not the result struct leading to off-by-one errorsAlso add some more tests to fully cover
date_time.cpp(which led to the discovery of the above bug),especially the
date_timeconstructors taking acalendarand the handling of the "active" time-zone were not sufficiently tested