ICU: Store time in second resolution #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ICU was the only backend storing subseconds in its calendar and hence reported fractional times in `date_time::time()` However outside of `date_time::time(floor(time))` there was no way setting those milli/nanoseconds. This leads to unexpected behavior for comparisons of seemingly identical time points, especially as it depends on the backend. Closes #221
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #222 +/- ##
===========================================
- Coverage 95.72% 95.70% -0.02%
===========================================
Files 116 116
Lines 9937 9946 +9
===========================================
+ Hits 9512 9519 +7
- Misses 425 427 +2
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ICU was the only backend storing subseconds in its calendar and hence reported fractional times in
date_time::time()However outside of
date_time::time(floor(time))there was no way setting those milli/nanoseconds.This leads to unexpected behavior for comparisons of seemingly identical time points, especially as it depends on the backend.
Closes #221